pywa
pywa copied to clipboard
Media Carousel implementation
Added functionality to create a media carousel template and to send it alongside unit tests to confirm the json it produces matches what we should expect based on metas documentation.
Hi, thanks. 🙂 We will check it out.
Codecov Report
:x: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 87.13%. Comparing base (90e2419) to head (e0ca1bb).
:warning: Report is 323 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pywa/types/template.py | 93.18% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 86.39% 87.13% +0.73%
==========================================
Files 16 16
Lines 3183 3226 +43
==========================================
+ Hits 2750 2811 +61
+ Misses 433 415 -18
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Hi @mhaugestad, Thanks a lot for this PR and for your effort in adding support for media carousels — it’s clear you put thought into the structure and alignment with Meta’s documentation.
Since this was opened, I’ve implemented carousel support separately in a way that better fits the internal design and direction of the library. My version also integrates more tightly with the revamped template system in v3, so I’ll be closing this PR.
That said, I truly appreciate your initiative — it helped reinforce the importance of supporting this feature, and your work wasn’t overlooked. Hope to see you contribute again in the future!
You can see the new class here: https://pywa.readthedocs.io/en/v3/content/templates/types.html#pywa.types.templates.Carousel
Hi @mhaugestad, Thanks a lot for this PR and for your effort in adding support for media carousels — it’s clear you put thought into the structure and alignment with Meta’s documentation.
Since this was opened, I’ve implemented carousel support separately in a way that better fits the internal design and direction of the library. My version also integrates more tightly with the revamped template system in v3, so I’ll be closing this PR.
That said, I truly appreciate your initiative — it helped reinforce the importance of supporting this feature, and your work wasn’t overlooked. Hope to see you contribute again in the future!
You can see the new class here: https://pywa.readthedocs.io/en/v3/content/templates/types.html#pywa.types.templates.Carousel
Thanks for all your efforts building and maintaining this library! Let me know if I can be of any help