ember-cli-rollbar icon indicating copy to clipboard operation
ember-cli-rollbar copied to clipboard

Published 20 hours ago • verified publisher icon davewasmer

index.js: use app argument instead of this.app

Open jonathanong opened this issue 8 years ago • 2 comments
trafficstars

fixes https://github.com/davewasmer/ember-cli-rollbar/issues/103

jonathanong avatar Aug 21 '17 18:08 jonathanong

@jonathanong would you mind linking to the docs that describe app.app here? I'd love to understand a bit more about why this change is necessary.

davewasmer avatar Sep 05 '17 22:09 davewasmer

I don't know if this is well documented, but I'm pretty sure the issue here is related to nesting add-ons. Since add-ons can be nested n levels deep, the reference to app could mean the user's application, or it could mean a parent add-on.

The fix in this PR has been used in several add-ons to ensure that the correct configuration is being referenced. Here is another example: https://github.com/rwjblue/ember-cli-pretender/commit/dda9bf88597e5f127cfbe0cf863f2b03c4e24246

It should be safe to merge this once the tests are fixed. 😄

jeffjewiss avatar Oct 09 '17 16:10 jeffjewiss