Dave Reid

Results 76 comments of Dave Reid
trafficstars

@IonBazan Can I get approval to run workflows in this PR while I continue to work on it?

Yeah, I'm not set on using make files either. In fact I'm making the way that patch files are stored pluggable with https://bitbucket.org/davereid/drush-patchfile/pull-request/3/add-support-for-pluggable-patchfile since there has been an interested in...

I'm definitely using drush-patchfile for patch management in a "entire" website project workflow, not as a contrib module maintainer workflow. The usefulness is helping easily record what patches are applied,...

PEAR is not required unless you are attempting to run the unit tests. It is not required to actually use the library.

I will note that the docs for the `vendor-bin` config don't include a trailing slash: > Defaults to `vendor/bin`. https://getcomposer.org/doc/06-config.md#bin-dir

I *suppose* that I could generate the full `COMPOSER_AUTH` environment variable too in my .zshenv, but I'd like to have this supported since other package managers support it.

> So anything which extends `DrushCommands` and doesn't have a `create` method, throw an error? Only if the module that owns that command file has a drush.services.yml file for dependency...

> Because if they do not, it's assumed it doesn't need dependency injection? I think it depends if there is a drush.services.yml record for that class that contains `arguments` or...

Well, I'm confused about the messaging from Drush about create() given that Drupal core also isn't strong on autowiring: > Prior methods such as a create() method or a drush.services.yml...

> OK, but the presence of drush.services.yml should _always_ trigger a warning. Its always good to remove it. If you have one AND you have autowire/create, you are doing the...