nativescript-filterable-listpicker icon indicating copy to clipboard operation
nativescript-filterable-listpicker copied to clipboard

enableSearch = false is ignored and search field is still visible

Open BearOutThere opened this issue 7 years ago • 0 comments

Make sure to check the demo app(s) for sample usage

Make sure to check the existing issues in this repository

If the demo apps cannot help and there is no issue for your problem, tell us about it

Please, ensure your title is less than 63 characters long and starts with a capital letter.

Which platform(s) does your issue occur on?

  • iOS/Android/Both - Android
  • iOS/Android versions - 27
  • emulator or device. What type of device? Android emulator

Please, provide the following version numbers that your issue occurs with:

  • CLI: (run tns --version to fetch it) - 4.2.0
  • Cross-platform modules: (check the 'version' attribute in the node_modules/tns-core-modules/package.json file in your project) - 4.2.1
  • Runtime(s): (look for the "tns-android" and "tns-ios" properties in the package.json file of your project) - 4.2.0
  • Plugin(s): (look for the version numbers in the package.json file of your project and paste your dependencies and devDependencies here) - 1.1.7

Please, tell us how to recreate the issue in as much detail as possible.

Describe the steps to reproduce it.

Even though picker.enableSearch = false the search text field is visible when the picker is shown. Stepping through the plugin code the check happens on line 161:

        if (this.enableSearch) {
            var textField = this.viewContainer.getViewById('filterTextField');
            if (JSON.parse(this.focusOnShow))
                textField.focus();
        }

and the value is false so the code is skipped but the field still shows up. It shouldn't.

Is there any code involved?

  • provide a code example to recreate the problem
  • (EVEN BETTER) provide a .zip with application or refer to a repository with application where the problem is reproducible.

BearOutThere avatar Oct 12 '18 05:10 BearOutThere