gcvis
gcvis copied to clipboard
davecheney
Allow the ability to save the graph.
This is a PR to fix #1, there are some limitations outlined bellow and I'll see if I can fix the transparent image later on.
Limitations: Currently FF saves with incorrect image extension and the background of the image is transparent (will fix later).
Nice!
Can you hold off for an hour or so, I'm trying to push a change that adds the ability to zoom in on a part of the graph, you'll need to merge with that.
On Fri, Jul 11, 2014 at 7:25 PM, Simon Richardson [email protected] wrote:
This is a PR to fix #1 https://github.com/davecheney/gcvis/issues/1, there are some limitations outlined bellow and I'll see if I can fix the transparent image later on.
Limitations: Currently FF saves with incorrect image extension and
the background of the image is transparent (will fix later).
You can merge this Pull Request by running
git pull https://github.com/SimonRichardson/gcvis master
Or view, comment on, or merge it at:
https://github.com/davecheney/gcvis/pull/3 Commit Summary
- Allow the ability to save the graph.
File Changes
- M main.go https://github.com/davecheney/gcvis/pull/3/files#diff-0 (18)
Patch Links:
- https://github.com/davecheney/gcvis/pull/3.patch
- https://github.com/davecheney/gcvis/pull/3.diff
— Reply to this email directly or view it on GitHub https://github.com/davecheney/gcvis/pull/3.
I've added the ability to see what's the gc is doing in some sort of delayed fashion. Essentially we poll the /ajax endpoint to retrieve the updates from the gc.
@SimonRichardson i'm sorry for not replying earlier. If you are still interested in landing this PR, please fix the merge conflicts and I'll merge it for you.
Perhaps this could be done with less code changes from the client-side like such: http://stackoverflow.com/questions/15616925/save-flot-graph-as-image?
@tonglil if you want to fix the conflicts, I'll be happy to review this branch.
