Dave

Results 42 comments of Dave

@mudler mind reviewing this when you get a chance? It's been sitting a while, so I did just merge master to shake out the dust.

> this coqui test started to be flaky lately, ugh I have been baby sitting that one for a few weeks now - it's unfortunately not related to PR content...

@mudler - cleaned up some things based on your comments. By default, the UI is once again fully protected. Endpoint skipping is now regex based, and fully configurable. The relevant...

@mudler This one will probably need a manual approval / merge on your part: I think there's github repo-side changes you'll need to make as the project admin to support...

Given that this branch is actually reporting green now - I think that my 2nd theory (skipped checks count as passed) may be true. Do you mind tossing a review...

@mudler I missed this while reading docs yesterday - it's absolutely the case that skipped checks count as passed: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks > Note: A job that is skipped will report its...

Interesting. It has not auto-merged. It seems that based on https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-jobs-in-a-workflow#defining-prerequisite-jobs we'll need to add a "report status" stage at the very end with `needs:` and `if: always()`. Given that...

Looks like another draft is in order. I'll update this soon.

I just took a quick look and I'm not seeing any code in our vllm gRPC backend to pass through token counts. Thank you for the heads up - this...

I also want to investigate https://buf.build/docs/ at this time - might help