shinymanager icon indicating copy to clipboard operation
shinymanager copied to clipboard

Published 20 hours ago • verified publisher icon datastorm-open

fix for #198

Open MikeWLloyd opened this issue 6 months ago • 3 comments

Per @ismirsehregal in https://github.com/datastorm-open/shinymanager/issues/198#issuecomment-2765726221, a minor fix is made to R/module-auth.R to remove the duplicate input ID, and avoid error popups being flashed to the screen on authentication.

MikeWLloyd avatar May 15 '25 13:05 MikeWLloyd

This change indeed fixed the duplicated ID issue. However, later I found out, that switching the language was no longer working correctly, so I rolled it back. Accordingly my PR only fixes the typos.

ismirsehregal avatar May 15 '25 15:05 ismirsehregal

Oh, I didn't follow that fully from the other PR. Do you have a recollection of how the language was no longer working?

MikeWLloyd avatar May 15 '25 15:05 MikeWLloyd

I think the issue was concerning use_language().

ismirsehregal avatar May 15 '25 15:05 ismirsehregal