csharp-driver
csharp-driver copied to clipboard
datastax
[CSHARP-969] - OpenTelemetry tracing RFC
As discussed in https://datastax-oss.atlassian.net/browse/CSHARP-969?focusedCommentId=55554, this document describes a proposal for the inclusion of tracing for C# driver that follows the OpenTelemetry specification.
It was based on the template available in the Rust lang repository and should be used as a support guide for the reading of the proposal https://github.com/rust-lang/rfcs/blob/master/0000-template.md
In the repository below, there is an incomplete POC developed by our team that can be viewed when analyzing the technical parts of the proposal: https://github.com/simaoribeiro/csharp-driver/pull/2
Hi, sorry for the delay. Now that the 3.20.0 release is out I can take a look at this.
Hi, sorry for the delay. Now that the 3.20.0 release is out I can take a look at this.
Thank you @joao-r-reis
Hi @joao-r-reis . I've been busy in the last couple of weeks but I will focus this PR again starting tomorrow.
Hi @joao-r-reis . I've been busy in the last couple of weeks but I will focus this PR again starting tomorrow.
Sounds good! No worries.
Can you move the files on this PR to a separate folder called proposals at the root of the repo? We don't really want to include this proposal in the driver docs that are published to https://docs.datastax.com/en/developer/csharp-driver/ as this proposal is meant more for contributors of the project while those driver docs are meant for users.
We will later need documentation for users but we'll worry about that after the feature is done.
@joao-r-reis Done. Do you want me to squash the commits and rebase?
No need, I always squash and merge on this repo.
Before I can merge this PR I need you guys to sign the CLA: https://cla.datastax.com/
I see that there are 2 co-authors:
Co-authored-by: Ailton Silva <[email protected]>
Co-authored-by: Rui Quintas Barbosa <[email protected]>
Hi @joao-r-reis , I think all the CLAs are signed.
Just a question: my CLA was signed used, by mistake, my personal email as it was the primary e-mail associated with my github account. However, the rest of the fields (including Company and GitHub Username) are correct. Do you think there is any problem? I can send a second one with the correct e-mail
Hi @joao-r-reis , I think all the CLAs are signed. Just a question: my CLA was signed used, by mistake, my personal email as it was the primary e-mail associated with my github account. However, the rest of the fields (including Company and GitHub Username) are correct. Do you think there is any problem? I can send a second one with the correct e-mail
Yeah please send a second one with the correct e-mail 👍
Hi @joao-r-reis , I sent an email to [email protected] with the correct document signed (as it looks like the GitHub integration doesn't allow edits for a given GitHub account).
I believe everything is fine now