dbachecks
dbachecks copied to clipboard
[WIP] Solve cross-platform import problem on MacOS build
Fixes #909
This change might solve the problem with the MacOS build.
Note: Unfortunately I encountered further errors in the build on my local machine to do with the New-Json function either not correctly establishing the path to the test repo I'm likely missing a dependency since Get-CheckRepo isn't available on my machine so submitting this PR first to see if it gets us any further.
postimport.ps1 is still being run, I just took out the Linux specialism and converted the paths so it should import on all 3 platforms. I think there's then problems with the New-Json function but that's a bit after this import problem.
You are right and I can't read :-) I have no idea what I saw - Apologies
Yes I have to fix some paths on those other functions
@stuartpreston I have updated a few other files as well Thank you very much for the prompt Its odd that only these files were the ones that fell over publicly May you test this please to see if it imports
and I have added the PR workflow so that it will run the tests too :-)
MacOs Test Results
1 files 548 suites 28s :stopwatch: 466 tests 128 :heavy_check_mark: 0 :zzz: 338 :x: 1 815 runs 128 :heavy_check_mark: 0 :zzz: 1 687 :x:
For more details on these failures, see this check.
Results for commit cd3f4c21.
Linux Test Results
1 files 548 suites 30s :stopwatch: 466 tests 128 :heavy_check_mark: 0 :zzz: 338 :x: 1 815 runs 128 :heavy_check_mark: 0 :zzz: 1 687 :x:
For more details on these failures, see this check.
Results for commit cd3f4c21.
WinPS51 Test Results
1 files 548 suites 25s :stopwatch: 466 tests 128 :heavy_check_mark: 0 :zzz: 338 :x: 1 815 runs 128 :heavy_check_mark: 0 :zzz: 1 687 :x:
For more details on these failures, see this check.
Results for commit cd3f4c21.
WinPS71 Test Results
1 files 548 suites 27s :stopwatch: 466 tests 128 :heavy_check_mark: 0 :zzz: 338 :x: 1 815 runs 128 :heavy_check_mark: 0 :zzz: 1 687 :x:
For more details on these failures, see this check.
Results for commit cd3f4c21.
Convert-Path shouldn't be required to support PowerShell on Mac or Linux.