dbachecks icon indicating copy to clipboard operation
dbachecks copied to clipboard

Add Pester V5 Instance Level Checks

Open SQLDBAWithABeard opened this issue 3 years ago • 2 comments

Add new v5 checks using the initfields method to gather the information in the most efficient manner for each of the Instance Unique checks - Validating that the performance is improved and the results are the same as the v4 existing checks using the

https://github.com/dataplat/dbachecks/blob/pesterv5/Get-AllInstanceInfo%20testing.ps1 as an example

Here are the checks that use SpConfigure running in v5

https://user-images.githubusercontent.com/6729780/165101742-dcc695a7-48cd-4cad-a720-7664a0bbbdf9.mp4

Invoke-DbcCheck Performance improvement running in v5 and with AllInstanceInfo Improvements

https://user-images.githubusercontent.com/6729780/165101803-d27cf7b0-9ce7-460d-a03f-7b89b692015e.mp4

Improving AllInstanceInfo performance

https://user-images.githubusercontent.com/6729780/165101666-7c7a3451-581d-49be-9e3e-12e0926f887d.mp4

  • [x] AdHocDistributedQueriesEnabled
  • [x] AdHocWorkload
  • [ ] ADUser
  • [x] AgentServiceAdmin
  • [x] BackupPathAccess
  • [ ] BuiltInAdmin
  • [x] CLREnabled
  • [X] CrossDBOwnershipChaining
  • [X] DAC
  • [x] DefaultBackupCompression
  • [x] DefaultFilePath
  • [X] DefaultTrace
  • [ ] EngineServiceAdmin
  • [x] ErrorLog
  • [x] ErrorLogCount
  • [ ] FullTextServiceAdmin
  • [x] HideInstance
  • [x] InstanceConnection
  • [x] LatestBuild
  • [x] LinkedServerConnection
  • [ ] LocalWindowsGroup
  • [x] LoginAuditFailed
  • [x] LoginAuditSuccessful
  • [x] LoginCheckPolicy
  • [x] LoginMustChange
  • [x] LoginPasswordExpiration
  • [x] MaxDopInstance
  • [x] MaxMemory
  • [x] MemoryDump
  • [x] ModelDbGrowth
  • [x] NetworkLatency
  • [X] OLEAutomation
  • [X] OLEAutomationProceduresDisabled
  • [x] OrphanedFile
  • [x] PublicPermission
  • [X] RemoteAccessDisabled
  • [x] SaDisabled
  • [x] SaExist
  • [x] SaRenamed
  • [X] ScanForStartupProceduresDisabled
  • [x] ServerNameMatch
  • [x] SqlAgentProxiesNoPublicRole
  • [ ] SqlBrowserServiceAccount
  • [x] SqlEngineServiceAccount
  • [X] SQLMailXPsDisabled
  • [x] SupportedBuild
  • [x] SuspectPageLimit
  • [ ] TempDbConfiguration
  • [x] TraceFlagsExpected
  • [x] TraceFlagsNotExpected
  • [x] TwoDigitYearCutoff
  • [x] WhoIsActiveInstalled
  • [x] XESessionRunning
  • [x] XESessionRunningAllowed
  • [x] XESessionStopped
  • [x] XpCmdShellDisabled

SQLDBAWithABeard avatar Apr 25 '22 14:04 SQLDBAWithABeard

Commits linked to this are

https://github.com/dataplat/dbachecks/commit/cf15b1531d125d0e0e03a2933a0e2d805d0ebc72 https://github.com/dataplat/dbachecks/commit/ac52c1b4f38dc896749a29da229626505ea4472c https://github.com/dataplat/dbachecks/commit/c2bc5bbac55a2ae4a9af5808084ce11fb9171966 https://github.com/dataplat/dbachecks/commit/fbbb81a988c520fe78dfe897213392e24568e02b https://github.com/dataplat/dbachecks/commit/756d2ffbae916b9a4b45f7472212a1fc9e9bae32

SQLDBAWithABeard avatar Apr 25 '22 14:04 SQLDBAWithABeard

https://github.com/dataplat/dbachecks/commit/dfea078d8cfdb0d0f2eeebd0bcc898afc39a4c49

SQLDBAWithABeard avatar Apr 28 '22 07:04 SQLDBAWithABeard