mosaic icon indicating copy to clipboard operation
mosaic copied to clipboard

Implement ST_ASEWKT

Open r3stl355 opened this issue 2 years ago • 6 comments

Translates a geometry into its representation in Extended Well-known Text (EWKT) format.

Added tests and docs

r3stl355 avatar May 15 '23 19:05 r3stl355

Codecov Report

Merging #378 (95b223e) into main (bb49756) will decrease coverage by 0.05%. The diff coverage is 98.63%.

:exclamation: Current head 95b223e differs from pull request most recent head 79b291c. Consider uploading reports for the commit 79b291c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   94.99%   94.94%   -0.05%     
==========================================
  Files         198      198              
  Lines        5655     5718      +63     
  Branches      181      171      -10     
==========================================
+ Hits         5372     5429      +57     
- Misses        283      289       +6     
Impacted Files Coverage Δ
...cks/labs/mosaic/core/geometry/GeometryReader.scala 100.00% <ø> (ø)
...tabricks/labs/mosaic/functions/MosaicContext.scala 97.36% <90.00%> (-0.14%) :arrow_down:
.../labs/mosaic/codegen/format/ConvertToCodeGen.scala 90.32% <100.00%> (+0.32%) :arrow_up:
...c/codegen/format/MosaicGeometryIOCodeGenESRI.scala 100.00% <100.00%> (ø)
...ic/codegen/format/MosaicGeometryIOCodeGenJTS.scala 100.00% <100.00%> (ø)
...labs/mosaic/core/geometry/MosaicGeometryESRI.scala 96.82% <100.00%> (+0.13%) :arrow_up:
.../labs/mosaic/core/geometry/MosaicGeometryJTS.scala 97.08% <100.00%> (+0.11%) :arrow_up:
...ks/labs/mosaic/core/geometry/api/GeometryAPI.scala 100.00% <100.00%> (ø)
...metrycollection/MosaicGeometryCollectionESRI.scala 97.72% <100.00%> (+0.02%) :arrow_up:
...ometrycollection/MosaicGeometryCollectionJTS.scala 100.00% <100.00%> (ø)
... and 13 more

... and 1 file with indirect coverage changes

codecov[bot] avatar May 15 '23 19:05 codecov[bot]

I'll add more tests

r3stl355 avatar May 15 '23 21:05 r3stl355

CodeCov report still shows the original commit results, last commit results can be see here and show all green: https://app.codecov.io/github/databrickslabs/mosaic/commit/95b223e4fcf8e32242d36a085dead3065453eee4

r3stl355 avatar May 17 '23 07:05 r3stl355

cleaned up and rebased

r3stl355 avatar May 23 '23 09:05 r3stl355

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant