mosaic icon indicating copy to clipboard operation
mosaic copied to clipboard

Fix raster docs based on Python docstrings

Open mihaigurau-tomtom opened this issue 2 years ago • 5 comments

Just a few small edits of the docs for Raster Functions, particularly regarding descriptions of returns for rst_rastertogridcount and rst_rastertogridmin.

I think it'd be nice to update the images for the rst_rastertogrid* functions as well, as they seem to be inconsistent & now all link to the output of rst_rastertogridavg. However, I couldn't generate the images myself, hence that change may be part of a different PR.

Cheers! :)

mihaigurau-tomtom avatar May 15 '23 18:05 mihaigurau-tomtom

@mihaigurau-tomtom We have now opened up the process for merging the external PRs. Can you please confirm with the: https://github.com/databrickslabs/mosaic/blob/main/CONTRIBUTING.md? After your PR is compliant, I am happy to review it and merge it if the review is successful.

milos-colic avatar May 31 '23 21:05 milos-colic

Codecov Report

Merging #377 (1ef9e02) into main (bb49756) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         198      198           
  Lines        5655     5655           
  Branches      181      181           
=======================================
  Hits         5372     5372           
  Misses        283      283           

codecov[bot] avatar May 31 '23 22:05 codecov[bot]

Hi @mihaigurau-tomtom , in order for us to proceed it is sufficient to add a comment to this PR with your sign-off (Eg. Signed-off-by: Joe Smith <[email protected]>). We need this to make sure you are aware of the current license, and that you agree with open sourcing it. :)

edurdevic avatar Aug 01 '23 12:08 edurdevic

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant