dbx
dbx copied to clipboard
Uses python:3.8-bullseye for GitLab CI stages.
Proposed changes
Closes #647 "python-3.8-stretch docker image does not exist in python_basic template with gitlab cicd."
by using python:3.8-bullseye docker image for all stages.
Types of changes
What types of changes does your code introduce to dbx?
Put an x in the boxes that apply
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
hi @j-4 thanks for contributing! could you please reflect the changes in the CHANGELOG as required?
Codecov Report
Merging #648 (522ff20) into main (ef672c4) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #648 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 97 97
Lines 3718 3718
Branches 466 466
=======================================
Hits 3483 3483
Misses 180 180
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Also, all commits should be signed. We don't accept unsigned commits for security reasons.
Hi @renardeinside,
thanks for your review. I made the requested changes and hope that it satisfy the requirements now :)
hi @j-4 , happy to merge your PRs, but first - could you please check if you've done the steps described here, specifically the CLA part?
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.
:x: j-4
:x: renardeinside
You have signed the CLA already but the status is still pending? Let us recheck it.
hey @j-4 , to close the loop on this one - please use Databricks Asset Bundles instead of dbx. If you still use dbx, please use a custom template.