dataframe-rules-engine icon indicating copy to clipboard operation
dataframe-rules-engine copied to clipboard

Fix Permitted Value for Expression Type Rules

Open goodwillpunning opened this issue 4 years ago • 3 comments

This commit corrects a display-only bug in the validation results when expression type Rules are used. Previously, the permitted column would display the Rule expression as a String. This commit updates the permitted column to the evaluated expression.

This commit also removes an unused object, Lookups.

goodwillpunning avatar Sep 23 '21 02:09 goodwillpunning

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ef9b9fa) 87.50% compared to head (fc4bfc9) 89.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   87.50%   89.63%   +2.13%     
==========================================
  Files           5        5              
  Lines         168      164       -4     
  Branches        3        4       +1     
==========================================
  Hits          147      147              
+ Misses         21       17       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 27 '23 20:11 codecov[bot]