terraform-provider-databricks icon indicating copy to clipboard operation
terraform-provider-databricks copied to clipboard

Fix sql table column type upper and lower mismatch error

Open case-k-git opened this issue 1 year ago • 2 comments

Changes

Terraform manage column type by lower case so if add the Upper case terraform Terraform manages column types in lowercase, so passing them in uppercase results in a column mismatch error.Even if not changing column type

fix this error https://github.com/databricks/terraform-provider-databricks/issues/3490

Tests

  • [x] make test run locally
  • [ ] relevant change in docs/ folder
  • [ ] covered with integration tests in internal/acceptance
  • [x] relevant acceptance tests are passing
  • [x] using Go SDK

case-k-git avatar Apr 23 '24 14:04 case-k-git

Hi @case-k-git, thanks for creating the PR, there were other issues that needed to be fixed (mapping) and I have created the PR to include this along with integration test: https://github.com/databricks/terraform-provider-databricks/pull/3528.

Once that is merged, can you please rebase and your PR with unit test can be merged after it.

tanmay-db avatar May 01 '24 12:05 tanmay-db

Hi @tanmay-db Thank you for your comment. Sure!!

case-k-git avatar May 04 '24 07:05 case-k-git

Hi @tanmay-db Resolve the conflict. Could you please check when you have time? Thank you.

--- PASS: TestResourceSqlTableUpdateTable_ColumnsTypeUpperLowerCaseThrowsError (0.54s)
PASS
ok  	github.com/databricks/terraform-provider-databricks/catalog	(cached)

case-k-git avatar Jun 03 '24 13:06 case-k-git

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.64%. Comparing base (67ab932) to head (9d0ef1d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3501   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files         193      193           
  Lines       19563    19563           
=======================================
  Hits        15973    15973           
  Misses       2637     2637           
  Partials      953      953           

codecov-commenter avatar Jun 04 '24 04:06 codecov-commenter

Hi @case-k-git, thanks for the PR.

tanmay-db avatar Jun 04 '24 04:06 tanmay-db