spark-deep-learning icon indicating copy to clipboard operation
spark-deep-learning copied to clipboard

Published 20 hours ago • verified publisher icon databricks

Linter

Open phi-dbq opened this issue 8 years ago • 2 comments

What changes are proposed in this pull request?

Add prospector for style checking, etc.

phi-dbq avatar Aug 10 '17 17:08 phi-dbq

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files          19       19           
  Lines         991      991           
  Branches        5        5           
=======================================
  Hits          843      843           
  Misses        148      148

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5a6e07...f1687a0. Read the comment docs.

codecov-io avatar Aug 10 '17 17:08 codecov-io

@phi-dbq thanks! Can you please document in the README (for example in running teh unit tests) that you need prospector installed with a link to the page of that tool? Also, I am surprised it has not found anything... Are there some good rules we have not turned on?

thunterdb avatar Aug 11 '17 17:08 thunterdb