databricks-sql-python icon indicating copy to clipboard operation
databricks-sql-python copied to clipboard
verified publisher icon databricks

"Export" `DatabricksDialect` from `databricks.sqlalchemy`

Open Kilo59 opened this issue 1 year ago • 2 comments

Although python doesn't really have an "Export/Re-export" command, type checkers like mypy will warn if an imported object isn't part of module's __all__ list.

https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport

With the ☝️ above rule enabled the following code will result in a mypy warning. With my proposed change, this will go away.

from databricks.sqlalchemy import DatabricksDialect

Kilo59 avatar Sep 17 '24 13:09 Kilo59

Thank you @Kilo59! Your change seems good. We currently have a code freeze due to some refactoring, but after that I'll merge your PR, and it will become available with the next release

kravets-levko avatar Sep 19 '24 09:09 kravets-levko

@kravets-levko any updates here?

Kilo59 avatar Dec 18 '24 13:12 Kilo59