databricks-sql-python icon indicating copy to clipboard operation
databricks-sql-python copied to clipboard
verified publisher icon databricks

Update the proxy authentication

Open amir-haroun opened this issue 1 year ago • 3 comments

This PR solves the proxy auth issue reported in #353. The idea is to use the proxy_headers argument of the ProxyManager instead of the Proxy-Authorization http header according to the API docs

amir-haroun avatar Feb 15 '24 14:02 amir-haroun

@rcypher-databricks, @arikfr , @yansonggao-db , @andrefurlan-db , @jackyhu-db ,@benc-db Can anyone take a look to this PR?

amir-haroun avatar Feb 19 '24 14:02 amir-haroun

@amir-haroun I was testing these changes a lot, and the code seems to work fine. I would like to ask you - can you add some tests for this code? Or maybe you can suggest some ideas on how to avoid regressions in future. Thank you!

kravets-levko avatar Feb 29 '24 18:02 kravets-levko

@kravets-levko, Not sure what can be added as unit tests here (especially for auth...) but we can verify if the proxies are set using urllib.getproxies().get('http')

amir-haroun avatar Mar 05 '24 11:03 amir-haroun