databricks-cli icon indicating copy to clipboard operation
databricks-cli copied to clipboard

Add tags to create_job, and add an update_job function to the sdk

Open ari-nz opened this issue 3 years ago • 4 comments

Add more REST api functionality to the python SDK

Issue #456

ari-nz avatar May 06 '22 01:05 ari-nz

Codecov Report

Merging #457 (c33aa30) into master (e427730) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files          42       42           
  Lines        3144     3144           
=======================================
  Hits         2667     2667           
  Misses        477      477           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e427730...c33aa30. Read the comment docs.

codecov-commenter avatar May 06 '22 01:05 codecov-commenter

@nfx - I've added a few more tests. Let me know if there's anything else specific that you need.

ari-nz avatar May 10 '22 01:05 ari-nz

@nfx I've rebased this fork back onto the latest version of main. It looks like the create_job api has been updated, but not the update_job

Requesting this PR to be merged

ari-nz avatar Jul 20 '22 01:07 ari-nz

Tagging @pietern too as it looks like you've been actively lately :)

ari-nz avatar Jul 20 '22 01:07 ari-nz

@ari-nz Thanks for the ping. We've picked up generating service.py from an internal definition of the API as of a couple of months ago, which is why the updated version of create_job appeared. I'll perform a regeneration and include update_job and pull in your tests.

pietern avatar Aug 18 '22 14:08 pietern