anyway icon indicating copy to clipboard operation
anyway copied to clipboard

2763 dont trigger telegram flow if no infographics

Open tkalir opened this issue 10 months ago • 2 comments

tkalir avatar Jan 14 '25 18:01 tkalir

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 2.63158% with 37 lines in your changes missing coverage. Please review.

Project coverage is 52.44%. Comparing base (07a333b) to head (763d643). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/telegram_accident_notifications.py 4.34% 22 Missing :warning:
anyway/infographic_image_generator.py 0.00% 15 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2764      +/-   ##
==========================================
- Coverage   52.57%   52.44%   -0.13%     
==========================================
  Files         122      122              
  Lines       10232    10256      +24     
==========================================
  Hits         5379     5379              
- Misses       4853     4877      +24     
Flag Coverage Δ
unittests 52.44% <2.63%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 14 '25 18:01 codecov-commenter

@tkalir looks good! Added small comments and also Pylint tests need to be fixed. After that I suggest we'll merge

atalyaalon avatar Jan 19 '25 11:01 atalyaalon