anyway
anyway copied to clipboard
Adding pagination fo news-flash api
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.
Project coverage is 52.77%. Comparing base (
400af13) to head (58bf0ec). Report is 98 commits behind head on dev.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| anyway/views/news_flash/api.py | 68.42% | 12 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## dev #2700 +/- ##
==========================================
- Coverage 53.22% 52.77% -0.46%
==========================================
Files 119 122 +3
Lines 9924 10102 +178
==========================================
+ Hits 5282 5331 +49
- Misses 4642 4771 +129
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 52.77% <68.42%> (-0.46%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ziv17 is there a FE change needed once this is merged to prod?
Also, is this closing this? https://github.com/data-for-change/anyway/issues/2697
@ziv17 is there a FE change needed once this is merged to prod?
No. The new behavior takes place only when one of the new parameters is supplied. As I wrote in the FE issue.
@ziv17 looks good!
Merging this one, next task in this issue is handling the use case when the news flash id is a param with pagination (I assume we'll need to modify get_news_flash_by_id
Also, is this closing this? #2697
It does not handle the newsflash I'd parameter. I will do that in the next PR