Daniel Strobusch

Results 68 comments of Daniel Strobusch
trafficstars

Is this fixed in v11.1.0 or v11.0.1? I did see it on the release notes.

> I'm assuming you meant you didn't see it in the release notes? Yes. Sorry for the typo. Thanks for the long explanation. I am looking forward to the next...

@arjan-bal sure, let me try to detail the described use case a bit. The Grafana Tempo distribute exposes a gRPC API to consume data. In the handler, the context is...

@purnesh42H, thanks for your question. The primary use case I was creating this issue for is the client-side request cancellation described in https://github.com/grpc/grpc-go/issues/7541#issuecomment-2306980949. There are certainly more scenarios, where causes...

@purnesh42H I am not sure I can follow your suggestion to detect request cancellation from a handler that offloads work to another goroutine. > which is inferred from the error...

@purnesh42H Great summary, that's exactly what I had in mind. I can work on drafting a PR in about three weeks, as I likely won't have time before then. Thanks...

I've put together a quick draft to help move the discussion forward. The tests and details still need further refinement, but this should give a good illustration of the idea...

> Why is the application responding to a cancellation by the client differently from connection loss? Can you give reasonable examples of why it would want to do anything differently...

Thanks for the comment, I'll look into the stats handler's next week.

It looks like the stats handler is providing some of the required information. Specifically, the `toRPCErr` function seems to offer the error API I was essentially suggesting, and it resembles...