dask-ml icon indicating copy to clipboard operation
dask-ml copied to clipboard

Implement `check_lengths`

Open TomAugspurger opened this issue 4 years ago • 2 comments
trafficstars

https://github.com/dask/dask-ml/pull/863/files#diff-970a9a902963a060977ac1912b5a86a5177cebfd468517967f63335bb6d024eaR435-R437 added an empty check_consistent_lengths. We should implement a real one.

Unlike scikit-learn, we don't actually want to check the lengths when constructing the graphs. But we do want to check things like that the number of chunks match, that the chunk shapes match if present, divisions, etc.

TomAugspurger avatar Oct 16 '21 16:10 TomAugspurger

@TomAugspurger Isn't that logic already implemented in check_matching_blocks ?

freddyaboulton avatar Jan 14 '22 00:01 freddyaboulton

Yep, that might just do the trick.

TomAugspurger avatar Jan 14 '22 17:01 TomAugspurger