dask-ml icon indicating copy to clipboard operation
dask-ml copied to clipboard

Published 20 hours ago • verified publisher icon dask

Closes #480

Open ryan-deak-zefr opened this issue 6 years ago • 2 comments
trafficstars

Reference Issues/PRs

Fixes #480. See also:

  • https://github.com/scikit-learn/scikit-learn/pull/13432
  • https://github.com/scikit-learn/scikit-learn/issues/4632
  • https://github.com/scikit-learn/scikit-learn/pull/10806

What does this implement/fix? Explain your changes.

This PR adds sample_weight to metrics in cross validation routines by propagating the sample_weight parameter passed to fit_params. It does not provide the ability to use different sample_weight values in validation.

Any other comments?

A scikit-learn version of this PR has been created at https://github.com/scikit-learn/scikit-learn/pull/13432

For more detailed information on the motivation for this PR, see http://deaktator.github.io/2019/03/10/the-error-in-the-comparator/

ryan-deak-zefr avatar Mar 11 '19 16:03 ryan-deak-zefr

Can you ping me here when the scikit-learn version is merged / closed? I don't have time to follow it at the moment.

TomAugspurger avatar Apr 05 '19 20:04 TomAugspurger

this might be of interest here: https://github.com/scikit-learn/scikit-learn/pull/26896 (and other metadata routing work we're doing now)

adrinjalali avatar Aug 09 '23 08:08 adrinjalali