json-schema-form icon indicating copy to clipboard operation
json-schema-form copied to clipboard

handleFileInput return base64encoded url now.

Open imranaalam opened this issue 4 years ago • 3 comments

by using readAsDataURL function instead readAsText; now all data formats would be easily read as encode64 which can be later changed back to original file. https://base64.guru/ image image

imranaalam avatar Jun 04 '21 07:06 imranaalam

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jun 05 '21 07:06 sonarqubecloud[bot]

DeepCode's analysis on #80ee1d found:

  • :x: 3 critical issues, :warning: 2 warnings, :information_source: 1 minor issue. :point_down:

Top issues

Description Example fixes
Unsanitized input from data from a remote resource flows into a member access and is used to access a property of a field assignment by name. This may allow a malicious user to access methods (e.g. toString) as opposed to regular properties of objects and cause a crash, remote code execution or more serious problems. This is known as a Prototype Pollution vulnerability. Occurrences: :wrench: Example fixes
Unsanitized input from data from a remote resource flows into get, where it is used as an URL to perform a request. This may result in a Server-Side Request Forgery vulnerability. Occurrences: :wrench: Example fixes
Unsanitized user input from data from a remote resource flows into RegExp, where it is used to build a regular expression. This may result in a Regular expression Denial of Service attack (reDOS). Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

ghost avatar Jun 05 '21 07:06 ghost

Thanks for the pull request. Can you please add an issue where you describe the issue you're fixing? Ideally, your change should be as small as possible (i.e. only fix the issue in the handle upload function). If you have other changes (let's say a styling improvement) I'd be best to make another pull request for that. This would help you tremendously and make sure we can merge your change asap so you can use it in the next version.

aeberhart avatar Jun 05 '21 10:06 aeberhart