dasbus
dasbus copied to clipboard
dasbus-project
Decrement the reference count on the invocation object in _method_callback
The caller is responsible for doing this according to: https://docs.gtk.org/gio/callback.DBusInterfaceMethodCallFunc.html
this should fix #80
Ok, fair enough. I've filed a bug against pygobject here (i've also referenced this patch, i hope that's OK) https://gitlab.gnome.org/GNOME/pygobject/-/issues/519
unfortunately, this bug seems to just get kicked back and forth between glib and pygobject.
I'm gonna keep running with the workaround from this PR; i don't think either of those projects are going to bend
As an update, i've written a PR for the pygobject library that also addresses this issue https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/219
As an update, i've written a PR for the pygobject library that also addresses this issue https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/219
That is great! Hopefully, it will work out this time. If it gets blocked again please let me know. In that case, I would merge your hotfix for dasbus as a temporary workaround, because I would like to see this issue fixed.
careful merging this though, because if/when the pygobject fix gets merged, you'll have a ref underflow for systems that have an updated pygobject...
careful merging this though, because if/when the pygobject fix gets merged, you'll have a ref underflow for systems that have an updated pygobject...
Yes: if merged, a version of PyGObject known to have this bug should be pinned, say PyGObject<=3.42.2 (for which I have ample experimental evidence that this patch is working) or PyGObject<=3.43.1 (which I have not yet tested).
By the way, is there a reason for which PyGObject is not listed as a explicit dependency for dasbus?
