dart icon indicating copy to clipboard operation
dart copied to clipboard

Document the Aspect, State, and Properties system

Open mxgrey opened this issue 7 years ago • 1 comments

There's some crazy complicated template black magic in dartsim. Most of it is hidden deeply away inside the implementation, but it may be discouraging to newcomers who are interested in contributing to the codebase.

I should document the design of the implementation. Hopefully that would make our implementations more approachable to new developers.

mxgrey avatar May 04 '18 17:05 mxgrey

FWIW for anyone wanting to track this issue, I think these are the major relevant PRs, including some very good explanations @mxgrey previously generated:

  • ShapeFrame and ShapeNode (initial inspiration for Aspects): #394 -> #608
  • Nodes and Addons sketch: #531 -> #598
  • Optionality of Addons: #607
  • Refactor to current Aspects, States, and Properties: #659

Wow, we hammered on this for a while, huh 😅

psigen avatar May 05 '18 13:05 psigen