source_span icon indicating copy to clipboard operation
source_span copied to clipboard

Published 20 hours ago • verified publisher icon dart-lang

SourceFile.getText is doing too many allocations

Open klavs opened this issue 6 years ago • 1 comments
trafficstars

I am stress-testing my parser and SourceFile.getText seems to be making unnecessary allocations. Isn't String.fromCharCodes(_decodedChars, start, end); a valid substitute? It appears to cause much less allocations this way.

https://github.com/dart-lang/source_span/blob/f9343087ba37f0cb089648b75fc30d99d2eb2c26/lib/src/file.dart#L216-L217

klavs avatar Jul 20 '19 13:07 klavs

Reopening since I have to revert this in https://github.com/dart-lang/source_span/pull/46

natebosch avatar Nov 14 '19 18:11 natebosch