source_span icon indicating copy to clipboard operation
source_span copied to clipboard

Published 20 hours ago • verified publisher icon dart-lang

Support textless spans

Open nex3 opened this issue 10 years ago • 3 comments
trafficstars

Currently SourceSpans are required to have text associated with them. However, this isn't always possible; for example, spans extracted from source maps won't necessarily have the text of the source or target available, nor should they need to. We should make text optional and make union() resilient to this.

nex3 avatar Apr 29 '15 22:04 nex3

Would a PR for this be accepted?

thosakwe avatar Jul 05 '17 22:07 thosakwe

Sure!

nex3 avatar Jul 05 '17 22:07 nex3

Awesome. I'll try to send one ASAP. Thanks for the fast response!

thosakwe avatar Jul 05 '17 22:07 thosakwe