sdk icon indicating copy to clipboard operation
sdk copied to clipboard

pkg/vm/test/transformations/ffi_test goes from flaky to Timeout failures

Open a-siva opened this issue 1 year ago • 2 comments
trafficstars

The tests

pkg/vm/test/transformations/ffi_test Timeout (expected Pass)

are failing on configurations

unittest-asserts-debug-linux-x64

a-siva avatar Feb 17 '24 00:02 a-siva

//cc @dcharkes

a-siva avatar Feb 17 '24 00:02 a-siva

Link to failure log https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-linux-debug/19552/overview

a-siva avatar Feb 17 '24 00:02 a-siva

This test runs multiple tests in sequence, and every time we add new features to the FFI we add tests.

We should consider setting up the tests differently so that not every test case is run in sequence. (Possibly also for the other transform tests. Edit: The type_flow tests are already split up in multiple folders.)

I'll just mark it slow for now.

Links:

  • https://dart-current-results.web.app/#/filter=pkg/vm/test/transformations/ffi_test&showAll
  • flakiness dashboard

dcharkes avatar Feb 19 '24 08:02 dcharkes

Closing for now.

a-siva avatar Feb 28 '24 21:02 a-siva