samples icon indicating copy to clipboard operation
samples copied to clipboard

Update primitives.def

Open jthompsonic opened this issue 2 years ago • 2 comments

A few tweaks needed -- library produced on windows is primitives.dll so we need library name "primitives"

we need to add free_pointer to the exports so we can access that function in the primitives.dart program (get an uncaught exception when trying to run the primitives.dart program as it is now).

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

jthompsonic avatar Jul 16 '23 03:07 jthompsonic

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 16 '23 03:07 google-cla[bot]

I filled out the Google CLA

jthompsonic avatar Jul 16 '23 03:07 jthompsonic