matcher icon indicating copy to clipboard operation
matcher copied to clipboard

Switch to `package:dart_flutter_team_lints`

Open mosuem opened this issue 1 year ago • 2 comments


  • [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

mosuem avatar Jul 10 '24 12:07 mosuem

dart pub get is failing because of package:test, which has a pubspec entry:

 # Use a tight version constraint to ensure that a constraint on matcher
 # properly constrains all features it provides.
 matcher: '>=0.12.16 <0.12.17'

Does this mean we need to upgrade the dependency in test first? And why have this tight upper bound anyhow? Don't we have semver to handle this?

mosuem avatar Jul 11 '24 07:07 mosuem

Does this mean we need to upgrade the dependency in test first?

We should instead just add a dependency_override in this package, on the test package. It might need to list a few of the related packages as well (test_api, test_core).

Does this mean we need to upgrade the dependency in test first? And why have this tight upper bound anyhow? Don't we have semver to handle this?

This is because package:test exports package:matcher.

jakemac53 avatar Jul 15 '24 19:07 jakemac53

Closing as the dart-lang/matcher repository is merged into the dart-lang/test monorepo. Please re-open this PR there!

mosuem avatar Oct 18 '24 08:10 mosuem