matcher
matcher copied to clipboard
Switch to `package:dart_flutter_team_lints`
- [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
- See our contributor guide for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before creating a PR.
- Contributions to our repos should follow the Dart style guide and use
dart format. - Most changes should add an entry to the changelog and may need to rev the pubspec package version.
- Changes to packages require corresponding tests.
Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
dart pub get is failing because of package:test, which has a pubspec entry:
# Use a tight version constraint to ensure that a constraint on matcher
# properly constrains all features it provides.
matcher: '>=0.12.16 <0.12.17'
Does this mean we need to upgrade the dependency in test first? And why have this tight upper bound anyhow? Don't we have semver to handle this?
Does this mean we need to upgrade the dependency in test first?
We should instead just add a dependency_override in this package, on the test package. It might need to list a few of the related packages as well (test_api, test_core).
Does this mean we need to upgrade the dependency in
testfirst? And why have this tight upper bound anyhow? Don't we have semver to handle this?
This is because package:test exports package:matcher.
Closing as the dart-lang/matcher repository is merged into the dart-lang/test monorepo. Please re-open this PR there!