http
http copied to clipboard
[java_http] Remove redundant files
After PR #980 is merged we no longer need java_http_test.dart, therefore the file will be removed in a future PR (context).
I'm wondering if we still need the other files generated by the Dart create command or can we remove them as well:
As we spoke about during the GSoC Sync meeting on 30th June, we plan to eventually include the same example from cupertino_http and cronet_http but which uses JavaClient. Should I create a new GitHub issue for including an example in package:java_http?
java_http :coffee: team: @brianquinlan @HosseinYousefi
Tracking issue: #957
java_http_base.dart can go.
java_http_example.dart should probably be replaced with the same example as used in cronet_http/cupertino_http.
I agree, it's a good idea to replace the example in java_http_example.dart with the same example used in cronet_http/cupertino_http.
java_http_example.dart currently uses code from java_http_base.dart, so we can remove java_http_base.dart after we've replaced the example code in java_http_example.dart with the sample example from cronet_http/cupertino_http.
Tasks
- [x] #1001
- [ ] Replace the example in
java_http_example.dartwith the same example used incronet_http/cupertino_http. - [ ] Remove
java_http_base.dart.