ecosystem icon indicating copy to clipboard operation
ecosystem copied to clipboard

remove the 'version' section from the health checks

Open devoncarew opened this issue 1 year ago • 4 comments

  • remove the 'version' section from the health checks

  • [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

devoncarew avatar Oct 08 '24 19:10 devoncarew

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.10.0 ready to publish firehose-v0.10.0
package:dart_flutter_team_lints 3.2.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions[bot] avatar Oct 08 '24 19:10 github-actions[bot]

Unhandled exception:
FormatException: "version" is not an allowed value for option "fail_on".
#0      Parser._validate (package:args/src/parser.dart:311:[21](https://github.com/dart-lang/ecosystem/actions/runs/11242751471/job/31257125949?pr=305#step:11:22))
#1      Parser._validateAllowed (package:args/src/parser.dart:349:5)
#2      Parser._setOption (package:args/src/parser.dart:329:9)
#3      Parser._readNextArgAsValue (package:args/src/parser.dart:125:5)
#4      Parser._handleLongOption (package:args/src/parser.dart:281:9)
#5      Parser._parseLongOption (package:args/src/parser.dart:[26](https://github.com/dart-lang/ecosystem/actions/runs/11242751471/job/31257125949?pr=305#step:11:27)4:12)
#6      Parser.parse (package:args/src/parser.dart:86:11)
#7      ArgParser.parse (package:args/src/arg_parser.dart:334:42)
#8      main (file:///home/runner/work/ecosystem/ecosystem/current_repo/pkgs/firehose/bin/health.dart:52:32)

devoncarew avatar Oct 08 '24 20:10 devoncarew

PR Health

Breaking changes :heavy_check_mark:
Package Change Current Version New Version Needed Version Looking good?
firehose Non-Breaking 0.9.3 0.10.0 0.9.4 :heavy_check_mark:
Changelog Entry :heavy_check_mark:
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage :heavy_check_mark:
File Coverage
pkgs/firehose/lib/src/health/health.dart :green_heart: 95 %
pkgs/firehose/lib/src/utils.dart :green_heart: 24 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks :heavy_check_mark:

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers :heavy_check_mark:
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

github-actions[bot] avatar Oct 08 '24 20:10 github-actions[bot]

@mosuem - thoughts on this in general? I think the publishing validation info from the health workflow is largely duplicative of the comment from the publishing automation workflow.

devoncarew avatar Oct 10 '24 17:10 devoncarew