build_web_compilers + DDC: inject warning if browser != chrome

[kevmoo]

If you're not using chrome when hitting a DDC-compiled app, you'll likely have a bad time.

Would be good to add some sort of warning to help folks who hit this and think that something is broken.

@efortuna hit this

CC @vsmenon

[vsmenon]

I think this is the same as:

https://github.com/dart-lang/webdev/issues/318

@grouma

[kevmoo]

Better to do it here – so even if folks aren't using webdev, they see it – right?

[vsmenon]

I believe the relevant logic was moved to webdev.

Note, I think this is only an issue if you pass --debug to webdev. Otherwise, gallery (e.g.) loads fine in Safari / FF.

[kevmoo]

But DDC isn't tested AT all on other browsers, right? I want to set expectations so we don't break folks...

On Fri, Apr 26, 2019 at 3:32 PM vsmenon [email protected] wrote:

I believe the relevant logic was moved to webdev.

Note, I think this is only an issue if you pass --debug to webdev. Otherwise, gallery (e.g.) loads fine in Safari / FF.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dart-lang/build/issues/2233#issuecomment-487221029, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAEFCRT3ABOEAZGJ5XH6ULPSN7G3ANCNFSM4HI2RPZA .

[vsmenon]

Yes, it's not tested / officially supported on other browsers. DevTools also won't work (it's based on Chrome Debug Protocol).

Might make sense to report that and continue. (I.e., not sure it makes sense to not try loading the app.)

[kevmoo]

Yeah, I was thinking of something like a bubble at the bottom of the screen or something. Ship it as part of the bootstrap JS in build_web_compilers or something.

On Fri, Apr 26, 2019 at 3:39 PM vsmenon [email protected] wrote:

Yes, it's not tested / officially supported on other browsers. DevTools also won't work (it's based on Chrome Debug Protocol).

Might make sense to report that and continue. (I.e., not sure it makes sense to not try loading the app.)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dart-lang/build/issues/2233#issuecomment-487222801, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAEFCXCWF7TAFLV45YSSDTPSOACZANCNFSM4HI2RPZA .

[vsmenon]

Here's a first cut:

https://github.com/dart-lang/webdev/pull/357

[jakemac53]

We did fix the devtools issue here - @kevmoo did we want to do a more general thing? I am not so sure given that ddc does generally work.

[kevmoo]

Happy to hold off – unless we get a lot of bug reports. Sound reasonable?

[jakemac53]

Sure, can we close the issue (if we are waiting for new issues anyways, we can just use those)