angular_ast

angular_ast copied to clipboard

Condense element types - remove EmbeddedTemplate and EmbeddedContent

7

This is a pretty big design change - I've decided to essentially remove 'EmbeddedTemplateAst' and 'EmbeddedContentAst'. TL;DR: Having three types had no purpose and just overcomplicated things. Reasoning: - At...

mk13

Opening a TODO assuming that https://github.com/dart-lang/angular_ast/pull/60 gets merged. This PR adds support for `` and ``. However, we may want to either test that `` is allowed, or specifically reject...

MichaelRFairhurst

After Pipe expression is implemented, it would be a good point to refactor some of the code to make it cleaner.

mk13

Not a trivial process; there are changes made within the angular_ast already to define the new Pipe expression, but implementing it is proving to be troublesome due to circular dependency...

mk13

Event-bound values are not entirely just Expression type, but List of statements (specifically ExpressionStatement). Adjust the ast to store these values instead of just "expression" type.

mk13

PR #345 in analyzer; once added remove the error from plugin to avoid redundant.

mk13

- [ ] Support parsing expressions without throwing when a failure occurs - [ ] Include offset data in `parseExpression` - [ ] Add `visitExpression` to `TemplateAstVisitor` - [ ]...

matanlurey

jonahwilliams

jonahwilliams