Darren Burns

Results 182 comments of Darren Burns
trafficstars

The new parser will be in the next Rich release. It does _not_ add table support - it just gets us to parity with all pre-existing features (although, it does...

@synrg That's great, thanks! I've added that to this PR so that we support strikethrough (cc @willmcgugan). @daniloegea Just polishing this up now, so should be getting merged relatively soon.

I'm not 100% sure I'm following what this is. What is the ANSI theme and how does it relate to the terminal theme/the colours from the design system?

I'm actually wondering if a developer explicitly specifies ANSI "red" in their code, should we really be modifying that? I actually think it would be astonishing, and a little bit...

Yeah, I'm aware of that - I think my first paragraph was poorly worded. Just to be clear I'm suggesting replacing `red` with `#ff0000`, so it's not impacted at all...

> The user is unlikely to be expecting #ff0000 there. I don't understand this at all to be honest. I can't see how they would ever be expecting a conversion...

> Why #ff0000 though? > ... > The ansi colors and CSS colors are different domains where the colors are different. Because having it just match CSS is the least...

Closely related/dupe of: https://github.com/Textualize/textual/issues/2269

I don't really understand the benefit of this - why would you want to have the line numbers be zero indexed?

@davep Yeah, I can see that being useful. Rich `Syntax` offers something similar IIRC.