Darren Burns

Results 182 comments of Darren Burns

@jisnardo Did the Plot class previously have that method? Don't recognise it.

Yes - it seems to be an issue where if you run the command palette snapshot tests *and* unit tests it produces different output vs running the command palette snapshots...

Yeah, I remember this issue was happening in the past, and adding that line seemed to workaround it. The issue seems to have returned though - the workaround is no...

If I recall correctly, the original issue was the the segments for the emoji had a different "color" attribute in the output SVG. Hardcoding the color in the CSS for...

Do we also need to hardcode the background color of the SearchIcon? 🤠 (Even if this does happen to fix it I'd still love to know what is going on...

Confirmed that hardcoding a non-`transparent` background in the `SearchIcon` DEFAULT_CSS resolves the snapshot test issue (e.g. `background: red;`). With that change in place, I can run the following commands and...

Also works if we get rid of the emoji, which is always a good solution 😉

I was thinking this is an issue around global caches - for example an `@lru_cache` is global and will persist across tests. Perhaps some background color is being computed from...

Tried but no luck. Although there are also some inside Rich that I didn't remove.

@TomJGooding This is still an issue, but if you run the tests with `make test` now, it'll distribute the tests across processes and is MUCH faster, so it makes this...