Gergely Daróczi comments

Results 156 comments of


                                            Gergely Daróczi

trafficstars

Use `session` in `log_shiny_input_changes` to detect testing environment and utilize namespaces for more informative logging

Thanks a ton, looks very promising! Could you please take a look at the failing unit tests?

Use `session` in `log_shiny_input_changes` to detect testing environment and utilize namespaces for more informative logging

sorry for the delay with getting back to this :facepalm: I've rerun the unit tests, but seeing the same error: ``` ── Failure ('test-CRANSKIP-hooks.R:101:5'): shiny input change is logged with...

Use `session` in `log_shiny_input_changes` to detect testing environment and utilize namespaces for more informative logging

since then, we switched using snapshots for testing, so that's causing some git conflict -- I'm looking into it

Investigate using po files with context

I think you can use space in the context as well, e.g. `argument na.rm`

Import glue

Thank you both! Originally, I wanted to keep `logger` 0-dep, but using `glue` by default, except if it's not installed, is indeed messy, so I'm OK with properly depending on...

Simplify `log_level()`

Sorry, I just got to this PR. You are absolutely right that the return value is not documented :disappointed: But that was explicitly requested e.g. in #26, so I think...