darktable icon indicating copy to clipboard operation
darktable copied to clipboard

Wrong order in selective copy when there are several instances of a module

Open EC1000 opened this issue 1 year ago • 5 comments

Describe the bug

Selective copy used to display the module in the same order as the history stack. The last edited module was then at the top (making it easy to edit a module and copy it quickly). This order does not seem to work anymore when there are several instances of a module. The second (and third, fourth...) instances are displayed at the top of the selective copy windows, instead of the last edited module (which comes just after).

Steps to reproduce

  1. Create two instances of a module, e.g. colorbalancergb
  2. Edit another module, e.g. exposure
  3. Ctrl+Maj+C to selective copy
  4. The second instance of color balance rgb is at the top, instead of the exposure module.

Expected behavior

Display the last edited module at the top of the selective copy windows.

Logfile | Screenshot | Screencast

image

Commit

No response

Where did you obtain darktable from?

OBS

darktable version

4.7.0~git643.a2babfa9-1+11386.1

What OS are you using?

Linux

What is the version of your OS?

Linux Mint 21.1 Cinnamon

Describe your system?

No response

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

EC1000 avatar Mar 09 '24 13:03 EC1000

Yes, that's expected as we really want to order to be on the multiple instance to ensure that when copied they are properly pasted into the target. At the moment I don't have the right SQL incantation for have exposure before and still have the 2nd instance of color balance rgb before the 1st.

See #16372.

TurboGit avatar Mar 09 '24 17:03 TurboGit

Thanks for the explanation. Does the order of the GUI in the selective copy has to be the order of application in the pixelpipe? Couldn't the GUI order be the same as in the history stack, but copy the pixelpipe order?

EC1000 avatar Mar 09 '24 22:03 EC1000

It could be different indeed, but that's not simple so for now we'll have to live with that for some more time.

TurboGit avatar Mar 10 '24 06:03 TurboGit

I understand :+1: In the meantime, it is easier to find the last modified module, now that I know the "logic" of the new order!

EC1000 avatar Mar 10 '24 10:03 EC1000

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar May 10 '24 00:05 github-actions[bot]

This issue was closed because it has been inactive for 300 days since being marked as stale. Please check if the newest release or nightly build has it fixed. Please, create a new issue if the issue is not fixed.

github-actions[bot] avatar Mar 06 '25 00:03 github-actions[bot]