darktable icon indicating copy to clipboard operation
darktable copied to clipboard

[Culling] Overlays are wider than needed

Open AxelG-DE opened this issue 2 years ago • 5 comments

Describe the bug

I think permanent overlays in culling are wider than necessary

Steps to reproduce

1 Go to culling mode (press x) 2 switch on permanent overlays 3 see the oddity

Expected behavior

overlays should be alligned with image

Logfile | Screenshot | Screencast

grafik

Commit

No response

Where did you install darktable from?

self compiled

darktable version

4.5.0+1066~g812e0fd3bd

What OS are you using?

Linux

What is the version of your OS?

gentoo

Describe your system?

  • OS : Linux - kernel 6.5.9-gentoo
  • Distro : Gentoo Base System release 2.14
  • Processor : Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
  • Memory : 32 GB (4 x 8 GB) + 5GB Swap
  • Graphics card0 : NVIDIA GeForce GTX 1060 6GB
  • Graphics card1 : NVIDIA GeForce RTX 2070 SUPER
  • Graphics driver : nvidia-drivers-535.113.01
  • OpenCL installed : Yes (opencl-headers-2023.04.17)
  • OpenCL activated : Yes
  • Xorg : xorg-server-21.1.9
  • Desktop : KDE 5
  • GTK+ : gtk+-3.24.38
  • gcc : 13.2.1_p20230826
  • cflags : CMAKE_FLAGS="-march=native-O2-mtune=native-pipe"
  • CMAKE_BUILD_TYPE : "Release"

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

see above

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

see above

AxelG-DE avatar Nov 02 '23 21:11 AxelG-DE

I'm not sure to understand, in culling mode (x) there is no overlay. How do you produce such a display?

TurboGit avatar Nov 03 '23 13:11 TurboGit

@TurboGit see my attached dt-porn :-D

https://github.com/darktable-org/darktable/assets/49004103/49b9924c-e6e3-451a-9ea3-383a3935a09a

AxelG-DE avatar Nov 03 '23 16:11 AxelG-DE

@AxelG-DE : Ok, I see now. @AlicVB can you have a look at this? TIA.

TurboGit avatar Nov 03 '23 16:11 TurboGit

On this problem, it's simply that we've kept it simple. In fact, the spacing you points is simply the spacing between the edge of the thumbnail and the image. On all the other overlays (those where the border of the thumbnail is visible)this is less obvious because of the border. So in this case it's normal for it to be displayed like that because the image info (reject icon, stars...) takes up the entire length of the thumbnail, so goes beyond the image.

Nilvus avatar Nov 17 '23 16:11 Nilvus

Lot better in current master, we may want to improve but that's won't be for 4.6.

TurboGit avatar Nov 30 '23 06:11 TurboGit

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Aug 06 '25 00:08 github-actions[bot]