region-rs icon indicating copy to clipboard operation
region-rs copied to clipboard

Region enumeration on linux & windows

Open CertainLach opened this issue 5 years ago • 2 comments

Currenly has dependence on git repo, as long as https://github.com/tinaun/gen-iter/pull/3 isn't merged

Also requires nightly for generators

CertainLach avatar Mar 04 '20 16:03 CertainLach

Sorry for leaving you without any input.

This is definitely an interesting addition once generators are stabilised. I'm a bit torn between keeping the library simple yet providing functionality for operations that are frequent.

Functionality similar to this, is something that I already utilise in detour-rs, but it's not as straight forward when it's not integrated directly into the region library, so this may be an apt addition.

darfink avatar May 29 '20 13:05 darfink

I've refactored the internal query implementation to use iterators instead, greatly inspired by this branch. I've merged it in master, but I've yet to release it.

I've implemented it for all OSs, and Windows/Linux excerpts can be seen here: https://github.com/darfink/region-rs/blob/02a1d48164efe9eb18adec1362fde6d72a55885a/src/os/linux.rs#L7-L26

https://github.com/darfink/region-rs/blob/02a1d48164efe9eb18adec1362fde6d72a55885a/src/os/windows.rs#L11-L55

darfink avatar Jun 01 '20 18:06 darfink

I think we can close this now, right?

morrisonlevi avatar Aug 27 '23 20:08 morrisonlevi

Yep, this is already implemented.

CertainLach avatar Aug 27 '23 21:08 CertainLach