php-sdk icon indicating copy to clipboard operation
php-sdk copied to clipboard

add support for TTL and time/interval formats in actor timers/reminders

Open dmitsh opened this issue 4 years ago • 6 comments
trafficstars

This feature has been implemented in Dapr runtime: dapr/dapr#2906

It needed to be available via the SDK.

dmitsh avatar Nov 23 '21 22:11 dmitsh

This is already implemented in the SDK via #96 code

withinboredom avatar Dec 04 '21 08:12 withinboredom

/reopen

dmitsh avatar Dec 04 '21 20:12 dmitsh

@withinboredom , from looking at the code, neither timer nor reminder have TTL in their constructor and logic.

dmitsh avatar Dec 04 '21 20:12 dmitsh

Maybe I misunderstood the issue. I thought this was already supported via ISO-8601 via the number of repetitions? How is this different? In PHP, we've used ISO-8601 since the beginning since it's built into PHP and the default way to specify a time span. It did some "best guess" when translating to the golang time lib (which doesn't have a concept of days and years (not every day has 24 hours nor every year 365 days).

withinboredom avatar Dec 05 '21 00:12 withinboredom

We have extended timer/reminder scheduling functionality in actors by supporting 3 time formats and adding TTL parameter. The details are here: https://docs.dapr.io/developing-applications/building-blocks/actors/howto-actors/#actor-timers-and-reminders https://www.youtube.com/watch?v=aUAgOlTBVjY#t=33m49s

Let me know if that provides sufficient clarification.

dmitsh avatar Dec 06 '21 17:12 dmitsh

Ah, I see what you mean! This is pretty cool. I'll add it in the next release!

withinboredom avatar Dec 07 '21 20:12 withinboredom