arc.js_legacy icon indicating copy to clipboard operation
arc.js_legacy copied to clipboard

implement a `shouldExecute` function in genesisProtocol

Open tsuberim opened this issue 7 years ago • 7 comments

Implement a function that checks if a proposal is after it's defined time period and needs to be executed (as per the discussion at: https://github.com/daostack/arc.js/issues/169). Use genesisProtocol.execute.call(..).

tsuberim avatar Apr 02 '18 15:04 tsuberim

@dev-matan-tsuberi Just checking: Are there any outstanding questions that need to be resolved about this? And do we still want this in Arc.js? Thanks.

dkent600 avatar Apr 08 '18 11:04 dkent600

No. Yes. I think we settled on having a function like that in Arc.js and an "Execute" button in alchemy.

tsuberim avatar Apr 08 '18 12:04 tsuberim

I actually think we settled on not showing these proposals at all in Alchemy :) so we may not need this.

tibetsprague avatar Apr 08 '18 12:04 tibetsprague

When have we decided that?

tsuberim avatar Apr 08 '18 12:04 tsuberim

@dev-matan-tsuberi it was adam's suggestion, and it makes sense to me. I do want to talk more about it with Aaron though a bit more

tibetsprague avatar Apr 08 '18 13:04 tibetsprague

OK, I'm moving this down on the priority list.

dkent600 avatar Apr 16 '18 15:04 dkent600