Daniel O’Connor
Daniel O’Connor
We should also rename the prop `dataTest` to `dataTestId` in the process. I propose that we do this in a few steps: 1. Add temporary support for both props and...
More context: https://github.com/yarnpkg/yarn/issues/7734#issuecomment-565558049 Downgrading Yarn may work, but I haven't tried that yet.
To reproduce: 1. Start development environment. 2. Open `www/src/pages/components/avatar/react/index.mdx`. 3. Change description. 4. Notice that description remains the same at `http://localhost:8090/components/avatar/react/`. It's possible that this is related to this issue:...
We've had a lot of interest in adding more iOS documentation to Thumbprint. We should add syntax highlighting for `swift`. Swift isn't included as a default language with `prism-react-renderer`, so...
@unzunz saw an issue were the `Image` couldn't correctly calculate the `sizes` attribute within a multi-step modal. `sizes` was getting set to `0px`. I imagine that this is because the...
https://twitter.com/ryanflorence/status/1084108070400098305?s=09 This is currently supported by Chrome. Worth doing?
 `Link` with a theme of `inherit` has a hover because it renders an `` and we have global CSS that sets `a:hover` to blue....
We've decided to support the LoaderDots on tertiary and caution buttons. They should use the `muted` theme (so should the secondary button). Context (private to Thumbtack employees): https://thumbtack.slack.com/archives/CD01CJT4G/p1579219509050800
The `thumbprint-codemods` package [includes `jscodeshift@^0.7.0` as a dependency](https://github.com/thumbtack/thumbprint/blob/master/packages/thumbprint-codemods/package.json) in the `package.json` file. This doesn't actually do anything though because the codemod script runs jscodeshift using `npx`. https://github.com/thumbtack/thumbprint/blob/4513e14a4e5d044e19be9556f3319be2b2618cf0/packages/thumbprint-codemods/index.js#L67-L83 `npx jscodeshift` will...
@georgeashworth Is working on a feature where we want a "Placeholder" option to be selected at first. We can achieve that by adding `disabled` to an `option` element, BUT, the...