Daniel O’Connor
Daniel O’Connor
I think we're running into this issue at @thumbtack. In particular, this affects us when trying to upgrade a package within a workspace. This snippet should reproduce the issue: ```bash...
Confirmed that downgrading Yarn to 1.16.0 works. Thanks for digging into this, @DavideDaniel. Saved me lots of time! Here are downgrade instructions for those that installed with Homebrew: https://github.com/thumbtack/thumbprint/issues/592#issuecomment-565564993
@dependabot recreate
@dependabot recreate
> As the list of classes grows, and this pattern propagates to other components, will there be adverse effects on the component bundle size? ie if every component is checking...
 The whitelist would only be 2.6kb. Could optimize further, if needed, by creating a regex instead of a whitelist.
Yeah, I could see positioning or `display` being helpful in the future.
Yeah, that's a good point. 👍
> Taking a step back and playing devil's advocate for a second, what is the tradeoff of just not doing this and forcing people to use wrapper divs? There are...
> Re: @benknight's example in his last comment, I'm leery about supporting the margin classname prop on every custom component, mainly for reasons cited in my first paragraph in this...