entity-controller icon indicating copy to clipboard operation
entity-controller copied to clipboard

Custom State Strings and service data incorrect

Open derekoharrow opened this issue 5 years ago • 0 comments

(1) The custom state strings are defined in the source code and outlined here - https://danobot.github.io/ec-docs/special/state-strings.

  • control_states_on and control_states_off are defined, but not used in the source code, so do nothing.
  • state_states_off is defined, but not used in the source code at all

(2) Service data is defined here - https://danobot.github.io/ec-docs/config-advanced/custom-params

  • service_data and service_data off seem to be used, but service_data_on is not referenced in the source code at all. Looks like it just uses service_data for turn_on and service_data_off for turn_off.

Also, it would be great if the documentation of state-strings could be updated to provide examples, as it's really hard to tell what is support to do what and how it works.

Thanks

derekoharrow avatar Nov 17 '20 15:11 derekoharrow