clabango icon indicating copy to clipboard operation
clabango copied to clipboard

Recursion detection

Open winks opened this issue 12 years ago • 3 comments

When I mentioned this on #clojure, @bitemyapp suggested I file an issue, although I don't see this as a real bug.

When doing silly things with includes and extends, I get a 500 server error after a long loading period (and a huge stacktrace.)

Easiest steps to reproduce: $ lein new luminus foo cd foo && vi src/foo/views/templates/about.html

insert into ~line 3 (after extends)

{% include "foo/views/templates/about.html" %}

then lein ring server-headless and surf to localhost:3000/about

This also works the other way round iirc, if you extend something that's including the file you work on - maybe it would make sense to add an arbitrary recursion limit of ~10 levels deep.

winks avatar May 21 '13 16:05 winks

Interesting. Would you like to take a shot at implementing some recursion detection?

danlarkin avatar May 24 '13 18:05 danlarkin

I'm sorry, not sure how I'd start and a little low on time right now.

It's not a huge issue, really, more of a nice-to-have feature. When I ran into this it took me like 10min to fix my includes.

winks avatar Jun 03 '13 07:06 winks

I will get around to looking at this but it might be a while, I'm super busy ATM.

danlarkin avatar Jun 07 '13 20:06 danlarkin