Daniil Soloviev

Results 18 comments of Daniil Soloviev
trafficstars

@endercrest #3136 which I suspect had the same root cause was fixed in the latest nightly (0.5.408), so this might be too.

Update - can confirm the issue isn't present in stale 0.11.4, if that helps narrow down when it was introduced.

Think I've identified the root cause: tempfile's implementation of `persist()` on Windows uses `MoveFileExW()` to move the temporary file to the permanent one ([source](https://github.com/Stebalien/tempfile/blob/73e92b3e8373e7bec563c9e1e7b7d896661363c1/src/file/imp/windows.rs#L89)), which may return before the file...

Re: the mingw code, it seems to account for some cases where it doesn't have permissions to modify the file. If it does, but still gets an access denied error,...

Nothing was lost, don't worry - think I actually found this while testing for #4136 😂 But yes I'm a big fan of the undo button!

@mtsgrd I think that would work well! I assumed there was some reason for the current behaviour hence my suggestion for the warning, but personally I can only think of...

@mtsgrd wondering if there has been any update on this? Have come across a few times where I've wanted to discard all changes to a file in a branch without...

@mtsgrd #4136 is another case that triggered the same error, but without changing line numbers - not sure if that would need its own regression test, or if it's also...