Daniel Shahaf

Edge case to consider: highlighting `$prefix/bin/zsh` in command position when the variable `$prefix` is unset or empty and `/bin/zsh` exists. I wonder if we can highlight `$prefix` as an elision...

Labelled "good first issue".

Wonder how to handle SH_WORD_SPLIT and null argument elision.

Thanks for the patch. I don't think alphabetical sorting would be the best choice. Instead, we could group the entries semantically — e.g., all styles related to the command word...

> I think the question is if the docs are intended more for reference or pedagogy. I assume that by "reference" you mean a random-access use case ("What's the `foo`...

> I'm not yet happy with loading a local theme. If a user sets ZSH_HIGHLIGHT_THEME=error-only and then happens to have a file in their current directory called error-only, it will...

How about allowing $ZSH_HIGHLIGHT_THEME to be a function name? I think this could be implemented in two ways, either by `if $ZSH_HIGHLIGHT_THEME; (( $? != 127 )); then` (where 127...

> I had thought of that, but what about people who want to use ~? Are there any other prefixes or does checking /\* and ~\* suffice? When would you...

Nice, thanks. When you write docs for this (which I accept doesn't need to be now — design is still in flux), it might be good to note that $ZSH_HIGHLIGHT_STYLE_DEFAULT...

Summarizing my discussion points from IRC: - Have `source /path/to/themes/default.zsh` abstracted into a `_zsh_highlight_load_theme default` - Support themes in .zshrc and in /provided/path/to/file/to/be/sourced - To this end, consider allowing $ZSH_HIGHLIGHT_THEME...